Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sheet data #1280

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update sheet data #1280

merged 1 commit into from
Jan 21, 2025

Conversation

Haselnussbomber
Copy link
Contributor

@Haselnussbomber Haselnussbomber commented Jan 20, 2025 •
edited
Loading

That's what happens when you don't have a generator for this. :P

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Jan 20, 2025
@Haselnussbomber
Copy link
Contributor Author

Interesting. Added MaxParticipants to my EXDSchema PR: xivdev/EXDSchema@10e6051 (#59)

@Haselnussbomber Haselnussbomber mentioned this pull request Jan 21, 2025
Merged
@Haselnussbomber
Copy link
Contributor Author

Moved data.yml changes into a new PR.

@github-actions GitHub Actions
Copy link
Contributor

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Game.Character: 1

TimelineContainer: 1

  • uint BannerTimelineIcon

FFXIVClientStructs.FFXIV.Client.Game.InstanceContent: 1

DynamicEvent: 2

  • ushort Unknown0
  • ushort Unknown1

@Haselnussbomber
Copy link
Contributor Author

Looks like nobody is using BannerTimelineIcon: https://github.com/search?q=BannerTimelineIcon+AND+NOT+path%3A%22FFXIVClientStructs%2F%22&type=code
And we shouldn't guarantee Unknown fields to be stable.

@pohky pohky merged commit 770f8b2 into aers:main Jan 21, 2025
3 of 4 checks passed
@Haselnussbomber Haselnussbomber deleted the sheet-updates branch January 21, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haselnussbomber @pohky