Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset of AtkArrayData.SubscribedAddonsCount #1307

Merged
merged 1 commit into from
Feb 15, 2025
+20 −3
Merged

Fix offset of AtkArrayData.SubscribedAddonsCount #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions FFXIVClientStructs/FFXIV/Component/GUI/AtkArrayData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ public unsafe partial struct AtkArrayData {
[FieldOffset(0x8)] public int Size;
[FieldOffset(0xC), FixedSizeArray] internal FixedSizeArray16<byte> _subscribedAddons;
[FieldOffset(0x1C)] public byte Unk1C;
[FieldOffset(0x1D)] public byte SubscribedAddonsCount;
[FieldOffset(0x1E)] public byte Unk1E;
[FieldOffset(0x1D)] public byte Unk1D;
[FieldOffset(0x1E), Obsolete("Offset of SubscribedAddonsCount was fixed", true)] public byte Unk1E;
[FieldOffset(0x1E)] public byte SubscribedAddonsCount;
/// <remarks>
/// 0 = No update pending<br/>
/// 1 = Update subscribed addons (specific flags are checked in AtkUnitManager.UpdateAddonByID)<br/>
Expand Down
18 changes: 17 additions & 1 deletion ida/data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6330,19 +6330,34 @@ classes:
Component::GUI::AtkArrayData:
vtbls:
- ea: 0x141F66DC8
vfuncs:
0: Dtor
1: FreeManagedData
funcs:
0x1405E23A0: SortSubscribedAddons
0x1405E2420: HasRefs
0x1405E2430: IsUnused
0x1405E2450: IncRef
0x1405E2480: DecRef
Component::GUI::NumberArrayData:
vtbls:
- ea: 0x141F66DD8
base: Component::GUI::AtkArrayData
funcs:
0x1405E25F0: SetValue
0x1405E24A0: ctor
0x1405E24E0: Finalizer
0x1405E2520: Initialize
0x1405E2590: SetValueIfDifferent
0x1405E25C0: SetValueUnsuppressable
0x1405E25F0: SetValue
0x1405E2620: SetValueForced
Component::GUI::StringArrayData:
vtbls:
- ea: 0x141F66DE8
base: Component::GUI::AtkArrayData
funcs:
0x1405E2640: Finalizer
0x1405E2710: Initialize
0x1405E28C0: SetValue
0x1405E2A90: SetValueUtf8
0x1405E2AF0: SetValueIfDifferent
Expand All @@ -6357,6 +6372,7 @@ classes:
base: Component::GUI::AtkArrayData
funcs:
0x140E277E0: SetValue # (this, int index, Client::UI::Agent::MapMarkerBase *marker)
0x1405E2D40: HasValueAtIndex
Component::GUI::AtkServer:
vtbls:
- ea: 0x141F66E08
Expand Down