-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deploy bytecode #116
Conversation
@thepiwo currently I need to compile "something" first before I can provide the actual bytecode. is this intended? |
and I think you need to remove the arguments verification if bytecode only is provided 🤔 |
yes, the idea is that you can change the bytecode to whatever you like, having it otherwise is a bigger refactoring |
I think this happens based on the ACI, which does need to be provided in order to interact anyways |
there still seems to be an argument check somehow at this point if we "wipe out" the ACI input. something relies on the compiled output and I need to compile "something" in order to be able to see the bytecode input field. as a workaround I could compile some contract that matches the numbers of arguments. but it would be better to not rely on that at all. still, I would be able to achieve what I want with some minor workaround. note: keeping the "default" or some "invalid" (non-matching arguments) source code compilation and just replacing the ACI with the actual ACI that matches the custom bytecode, does NOT work |
8a8332b
to
51f7375
Compare
@marc0olo I pushed a refactoring which should allow deployment without compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #115