Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deploy bytecode #116

Merged
merged 5 commits into from
Sep 12, 2023
Merged

refactor: deploy bytecode #116

merged 5 commits into from
Sep 12, 2023

Conversation

thepiwo
Copy link
Collaborator

@thepiwo thepiwo commented Aug 28, 2023

closes #115

@thepiwo thepiwo requested a review from marc0olo August 28, 2023 19:25
@marc0olo
Copy link

@thepiwo currently I need to compile "something" first before I can provide the actual bytecode. is this intended?

image

@marc0olo
Copy link

and I think you need to remove the arguments verification if bytecode only is provided 🤔

@thepiwo
Copy link
Collaborator Author

thepiwo commented Aug 29, 2023

yes, the idea is that you can change the bytecode to whatever you like, having it otherwise is a bigger refactoring

@thepiwo
Copy link
Collaborator Author

thepiwo commented Aug 29, 2023

and I think you need to remove the arguments verification if bytecode only is provided 🤔

I think this happens based on the ACI, which does need to be provided in order to interact anyways

@marc0olo
Copy link

I think this happens based on the ACI, which does need to be provided in order to interact anyways

there still seems to be an argument check somehow at this point if we "wipe out" the ACI input. something relies on the compiled output and I need to compile "something" in order to be able to see the bytecode input field. as a workaround I could compile some contract that matches the numbers of arguments. but it would be better to not rely on that at all.

still, I would be able to achieve what I want with some minor workaround.

note: keeping the "default" or some "invalid" (non-matching arguments) source code compilation and just replacing the ACI with the actual ACI that matches the custom bytecode, does NOT work

@thepiwo thepiwo self-assigned this Aug 30, 2023
@thepiwo thepiwo force-pushed the refactor/deploy-bytecode branch from 8a8332b to 51f7375 Compare September 1, 2023 12:14
@thepiwo
Copy link
Collaborator Author

thepiwo commented Sep 1, 2023

@marc0olo I pushed a refactoring which should allow deployment without compile

Copy link

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepiwo I just accidentially provided a string argument with quotations when testing the deployment. I opened an issue for that: #118

other than that it works perfect, thanks! 🙏

@thepiwo thepiwo merged commit 5c2ce76 into master Sep 12, 2023
@davidyuk davidyuk deleted the refactor/deploy-bytecode branch October 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow to provide arbitrary bytecode for deployment
2 participants