chore: update sdk to 14, improve types #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
update-sdk
branch
2 times, most recently
from
166e23d to
54bf693
Compare
thepiwo
reviewed
Oct 21, 2024
| onDisconnect: () => alert("Aepp is disconnected"), | ||
| async function setupWalletConnector() { | ||
| status.value = Status.WALLET_SCANNING; | ||
| disconnectWallet(); |
There was a problem hiding this comment.
maybe add await or void for this async function call
There was a problem hiding this comment.
It is a mistake, there is no disconnect confirmation on the wallet side, so disconnectWallet runs in sync. I'm removing async from its definition.
src/stores/sdkStore.ts
Outdated
| } | ||
| } | ||
|
|
||
| updateConnectionInfo(); |
There was a problem hiding this comment.
maybe add await or void for this async function call
| ) { | ||
| status.value = Status.UNINITIALIZED; | ||
| if (customNodeUrl) nodeUrl.value = customNodeUrl; | ||
| else nodeUrl.value = nodes[0].instance.$host; | ||
| disconnectWallet(); |
There was a problem hiding this comment.
maybe add await or void for this async function call
There was a problem hiding this comment.
It is called in defineStore which can't be async, I'll add void. I think it is fine since exceptions are handled inside updateConnectionInfo.
thepiwo
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Foundation