Initial sync from aeternity repo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
here it is: aeternity/aeternity#2635 |
venimus
approved these changes
Aug 12, 2019
tolbrino
approved these changes
Aug 12, 2019
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # As this script might be used as docker health check it should exit with either 0/1 | |||
There was a problem hiding this comment.
This script seems duplicated in other repo https://github.com/aeternity/aeternity/pull/2635/files
Would it be possible to at least comment in one of the two which one the canonical script is?
There was a problem hiding this comment.
There was a problem hiding this comment.
It's different content/script now, this repo holds an extended version and it's used to check this repo only nodes.
The script in the aeternity repo is used to be embedded in the docker image as HEALTHCHECK
lucafavatella
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this initial sync this repo should be tagged as v1.0.0
Related: aeternity/aeternity#2635
PT Ticket