Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reply only for a selected comment #1070

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

AtanasKrondev
Copy link
Contributor

Fixes #914

--->

@github-actions
Copy link

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.
Except that the web wallet in a separate tab and web wallet (iframe) on superhero UI are not synchronized fully.
if I open web wallet in one window and URL in another, there was no My Profile after syncing to superhero.
I tried to leave a comment and saw a gravatar (like an unknown profile), but the comment was subscribed from the iframe wallet:

2021-04-28.3.16.58.mov

@AtanasKrondev AtanasKrondev force-pushed the feature/hide-sepparate-replies branch from 7838bf1 to 50c57be Compare May 3, 2021 10:04
@stale
Copy link

stale bot commented May 10, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 10, 2021
@AtanasKrondev AtanasKrondev force-pushed the feature/hide-sepparate-replies branch from 50c57be to b7d9332 Compare May 11, 2021 09:36
@stale stale bot removed the stale label May 11, 2021
@AtanasKrondev AtanasKrondev force-pushed the feature/hide-sepparate-replies branch from b7d9332 to 712ad26 Compare May 14, 2021 11:51
@stale
Copy link

stale bot commented May 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2021
@stale stale bot closed this May 24, 2021
@AtanasKrondev AtanasKrondev reopened this Jun 17, 2021
@stale stale bot removed the stale label Jun 17, 2021
@AtanasKrondev AtanasKrondev force-pushed the feature/hide-sepparate-replies branch from 712ad26 to 79d31e0 Compare June 17, 2021 08:08
@AtanasKrondev AtanasKrondev force-pushed the feature/hide-sepparate-replies branch from 79d31e0 to 5e0dc84 Compare June 18, 2021 09:40
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

Except for bad sync between UI and Web Wallet if they were open in separate tabs:
Safari ver. 14.1.1 (16611.2.7.1.4) and Web wallet commit c77cc41 / v.0.7.2

icon

@AtanasKrondev AtanasKrondev merged commit c9db166 into develop Jun 18, 2021
@AtanasKrondev AtanasKrondev deleted the feature/hide-sepparate-replies branch June 18, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide separate comments under the post
3 participants