Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shrink button to the right section #665

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add shrink button to the right section #665

merged 1 commit into from
Jul 1, 2020

Conversation

CedrikNikita
Copy link
Collaborator

@CedrikNikita CedrikNikita commented Jun 25, 2020 •
edited
Loading

fixes #661
ref superhero-com/superhero-wallet#407
This PR could be tested by changing this line to this
walletUrl: feature-integrated-wallet-new-designs.wallet.z52da5wt.xyz,

@CedrikNikita CedrikNikita force-pushed the feature/add-shrink-button-right-section branch from e25c377 to 57c324d Compare June 25, 2020 04:51
@mradkov
Copy link
Contributor

mradkov commented Jun 25, 2020

Initially the wallet should be extended.

@CedrikNikita CedrikNikita force-pushed the feature/add-shrink-button-right-section branch from 57c324d to 5a1d4c1 Compare June 25, 2020 05:46
@davidyuk davidyuk force-pushed the feature/integrated-wallet branch 4 times, most recently from 66d602e to d40f5af Compare June 25, 2020 13:06
@CedrikNikita CedrikNikita force-pushed the feature/add-shrink-button-right-section branch from 5a1d4c1 to 3a763e8 Compare July 1, 2020 05:34
@CedrikNikita CedrikNikita mentioned this pull request Jul 1, 2020
Merged
@mradkov mradkov self-requested a review July 1, 2020 21:03
mradkov
mradkov approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button itself looks good and behaves as intended. The view in the shrank wallet should be different though but this is another issue.

@mradkov mradkov merged commit e185971 into feature/integrated-wallet Jul 1, 2020
@mradkov mradkov deleted the feature/add-shrink-button-right-section branch July 1, 2020 21:15
@mradkov mradkov mentioned this pull request Jul 2, 2020
Merged
@mradkov mradkov added this to the 0.1.12 milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mradkov mradkov mradkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.12
Development

Successfully merging this pull request may close these issues.
2 participants
@CedrikNikita @mradkov