Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TipRecord: Simplify condition #711

Merged
merged 2 commits into from
Jul 15, 2020
Merged

TipRecord: Simplify condition #711

merged 2 commits into from
Jul 15, 2020

Conversation

davidyuk
Copy link
Member

No description provided.

@davidyuk davidyuk marked this pull request as draft July 14, 2020 07:40
@davidyuk
Copy link
Member Author

@stanislav-slavov is it computed variable really needed? As I see SingleComment doesn't render any TipRecords

@davidyuk davidyuk marked this pull request as ready for review July 14, 2020 07:44
@stanislav-slavov
Copy link
Contributor

@stanislav-slavov is it computed variable really needed? As I see SingleComment doesn't render any TipRecords

Yeah, it seems redundant now.

@davidyuk davidyuk merged commit b1ea876 into develop Jul 15, 2020
@davidyuk davidyuk deleted the feature/simplify-condition branch July 15, 2020 01:49
@mradkov mradkov mentioned this pull request Jul 21, 2020
Merged
@mradkov mradkov added this to the 0.1.13 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislav-slavov stanislav-slavov stanislav-slavov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@davidyuk @stanislav-slavov @mradkov