Increase iframe wallet timeout, add a button to enable it manually #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
featire/fix-iframe-wallet
branch
from
a90fdb4 to
dd9aafb
Compare
davidyuk
commented
Oct 9, 2020
| @@ -58,10 +58,7 @@ | |||
| v-if="!isLoggedIn" | |||
| class="login-footer" | |||
| > | |||
| <OutlinedButton | |||
| :to="addressDeepLink" | |||
| :title="$t('components.layout.FooterSection.LoginWithWallet')" | |||
There was a problem hiding this comment.
why do we need title the same as the text on button?
CedrikNikita
approved these changes
Oct 12, 2020
mradkov
approved these changes
Oct 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original issue: on #810 web wallet sometimes is opening even if the extension is installed
The increasing of timeout helps in that case, so probably app initialization takes a bit longer on that branch. But initialization time also depends on the hardware and network conditions so, as in superhero-com/superhero-wallet#540, I'm proposing to don't depend on timeouts.
In particular, I think we should increase the timeout so some upper bound (10 seconds instead of 2?) and to allow the user to open the web wallet manually if he wants to use it. Until we find a way to use the extension and the web wallet simultaneously (#606).