Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Code #41

Merged
merged 6 commits into from
May 31, 2022
Merged

Refactor Code #41

merged 6 commits into from
May 31, 2022

Conversation

aexolate
Copy link
Owner

@aexolate aexolate commented May 30, 2022 •
edited
Loading

  • Added src/components, constants, utils to separate different parts of the code
  • Created distance.js in src/utils for distance calculation function
  • Created Constants.js in src/constants for constant values and variables used in program
  • Changed .prettierrc style to enforce arrowParenthesis
  • Added SearchbarLocation and SnackbarHint in src/components and replaced code in App.js.
  • SearchbarLocation - Searchbar used to search for location using geocoding using expo-location Location.geocodeAsync(). Will call onResultReady() when a search result is found successfully.
  • SnackbarHint - Snackbar used to display information on how to use the application
  • Added WaypointIndicator (not fully finished yet)

@aexolate aexolate added this to the Milestone 2 milestone May 30, 2022
@aexolate aexolate linked an issue May 30, 2022 that may be closed by this pull request
Shift code to components #40
Closed
@aexolate aexolate added the enhancement New feature or request label May 30, 2022
@aexolate aexolate self-assigned this May 30, 2022
@aexolate aexolate requested a review from nus-jeff May 30, 2022 17:23
@nus-jeff nus-jeff merged commit 2e586e7 into master May 31, 2022
@aexolate aexolate deleted the cleanup branch May 31, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nus-jeff nus-jeff nus-jeff approved these changes

Assignees

@aexolate aexolate

Labels
enhancement New feature or request
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

Shift code to components
2 participants
@aexolate @nus-jeff