Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify column dtypes in dataset definitions #593

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

dkrako
Copy link
Contributor

@dkrako dkrako commented Oct 6, 2023

Description

As discussed in today's meeting, #517 probably comes from lots of na-rows in the beginning of a file and faulty inferrence of the column datatype.

Hopefully fixes issue #517

Implemented changes

  • Specify column dtypes in all public datasets

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

No additional tests written.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (78b649c) 100.00% compared to head (500dfe4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #593   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         2331      2337    +6     
  Branches       581       582    +1     
=========================================
+ Hits          2331      2337    +6     
Files Coverage Δ
src/pymovements/datasets/gazebase.py 100.00% <100.00%> (ø)
src/pymovements/datasets/gazebasevr.py 100.00% <100.00%> (ø)
src/pymovements/datasets/hbn.py 100.00% <ø> (ø)
src/pymovements/datasets/judo1000.py 100.00% <100.00%> (ø)
src/pymovements/datasets/sb_sat.py 100.00% <ø> (ø)
src/pymovements/datasets/toy_dataset.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkrako dkrako marked this pull request as ready for review October 6, 2023 12:11
@dkrako
Copy link
Contributor Author

dkrako commented Oct 6, 2023

#591 has shown that this PR effectively resolves #517

@dkrako dkrako enabled auto-merge (squash) October 6, 2023 15:08
@dkrako
Copy link
Contributor Author

dkrako commented Oct 10, 2023

@prassepaul @SiQube
this is ready for review and resolves the bug in #517

@dkrako dkrako merged commit 8836275 into main Oct 10, 2023
15 checks passed
@dkrako dkrako deleted the hotfix/gazebase-definition branch October 10, 2023 08:49
@dkrako dkrako added the fix label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants