Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml public datasets loader #914

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Yaml public datasets loader #914

wants to merge 20 commits into from

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Jan 1, 2025

first steps towards #908

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 72.30769% with 18 lines in your changes missing coverage. Please review.

Project coverage is 32.59%. Comparing base (a364c46) to head (a9deb54).

Files with missing lines Patch % Lines
src/pymovements/dataset/yaml_dataset_loader.py 78.37% 7 Missing and 1 partial ⚠️
src/pymovements/dataset/dataset.py 16.66% 5 Missing ⚠️
src/pymovements/dataset/dataset_library.py 73.68% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #914       +/-   ##
============================================
- Coverage   100.00%   32.59%   -67.41%     
============================================
  Files           74       58       -16     
  Lines         3419     3031      -388     
  Branches       613      620        +7     
============================================
- Hits          3419      988     -2431     
- Misses           0     2003     +2003     
- Partials         0       40       +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube
Copy link
Member Author

SiQube commented Jan 8, 2025

  • pymovements.datasets.BSC => pymovements.DatasetDefinition('BSC')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant