-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support missing dummy row in asc files #918
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 3422 3422
Branches 613 613
=========================================
Hits 3422 3422 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
finally I managed to incorporate the example file into the tests. ready for review @SiQube @prassepaul @senisioi |
I'm not too familiar with this branch of pymovements -- maybe @saeub could review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@saphjra and I also tested with some "real" ASC files converted with and without the -input
flag, and everything seems to work.
Description
Fixes #917
Implemented changes
Type of change
How Has This Been Tested?
eyelink_monocular_no_dummy_example.asc
functional/gaze_file_processing_test.py
unit/gaze/io/asc_test.py
Checklist: