-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #92
Conversation
package.json
Outdated
@@ -63,5 +63,6 @@ | |||
"npm run prettier-ts -- --write", | |||
"git add" | |||
] | |||
} | |||
}, | |||
"prettier": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People may have their editor configured with default prettier settings. Explicitly setting an empty config ensures that the default settings are used instead of those set by the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour, dunno if @af is, though 🙂
@@ -0,0 +1,3114 @@ | |||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could make this an npm lockfile if you prefer.
The advantage of having this is that in the event that a dependency of envalid is broken you can see from this lockfile what exact versions of modules are working, and then debug from this point.
@SimenB Out of curiosity, what do you use that depends on this? I don't see Jest using it. We use Envalid at a company I'm working with. We were adding Cypress tests and Envalid didn't work so I used Yup instead as a stopgap. This has me thinking, maybe I think it would be easy to add things like #81 (and also url validation) if Regarding the size of |
I use it at work 🙂 Just for backend though, not client side (web or RN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've resisted ^
in the past because I still don't like the idea of dependencies being declared inexactly. Besides the possibilities of bugs being shipped in patch versions of deps (it happens), there's the potential vulnerabilities of left-pad
/event-stream
- type incidents.
That said, you're right that lockfiles are now the norm (I've been using them for a few years so I realize the above borders on paranoia :P). I'll relent on this and we can re-assess if any issues come up. Thanks for the PR!
Also published v4.2.0! Thanks for the reminder, that was overdue |
* Update dependencies * Update husky config to new format, see: https://github.com/typicode/husky#upgrading-from-014
Using
^
in versions is less risky now because almost all consumers will be using newer yarn or npm versions, which both use lockfiles.In the event a dependency is broken users can easily fix it using yarn or npm resolutions.
Advantages:
Also a new version release would be appreciated, although I understand if you're busy.