Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FolderNameFilter now looks at all folders that a message is in. #145

Merged
merged 2 commits into from
Aug 1, 2017
Merged

FolderNameFilter now looks at all folders that a message is in. #145

merged 2 commits into from
Aug 1, 2017

Conversation

GuillaumeSeren
Copy link
Collaborator

Switched from message.get_filename() to message.get_filenames() and added appropriate processing to handle the list of file names.

This is a rebased version of the #74

@GuillaumeSeren GuillaumeSeren mentioned this pull request May 29, 2017
Closed
@GuillaumeSeren
Copy link
Collaborator Author

GuillaumeSeren commented May 29, 2017 •
edited
Loading

I have rebased the branch but not tested it intensively so I need some help on that 🍺 @daewok @varak @flokli @lucc

@varac
Copy link

varac commented May 29, 2017

I used this branch already for a while now and it works for me. But I wouldn't call this extensive testing.

@GuillaumeSeren
Copy link
Collaborator Author

@varac Thank you for the feedback 🍺
I will let the patch wait for a bit more reviews

@flokli
Copy link
Member

flokli commented May 30, 2017

@GuillaumeSeren: I think this might need a bit usage documentation, and we probably also should start adding some tests…

flokli
flokli requested changes Jun 19, 2017
View reviewed changes
Copy link
Member

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also update docs/source/filters.rst?

@flokli flokli added this to the 1.2.0 milestone Jun 19, 2017
@wyleyr wyleyr mentioned this pull request Jul 20, 2017
Closed
daewok and others added 2 commits July 20, 2017 11:33
@daewok @GuillaumeSeren
FolderNameFilter now looks at all folders that a message is in.
a0bb668 
Switched from message.get_filename() to message.get_filenames() and added appropriate processing to handle the list of file names.
@GuillaumeSeren
Upgrade filters doc for multiple location
86bcdd6 
Needed by afewmail#145

afewmail#145
afewmail#74
@GuillaumeSeren GuillaumeSeren force-pushed the FolderNameFilter-manage-multiple-folder branch from 9b08a38 to 86bcdd6 Compare July 20, 2017 09:50
@GuillaumeSeren
Copy link
Collaborator Author

Hey @flokli ,
I have added a bit of documentation in the branch, please have a look at it.

Also, I have seen the #152, that was more or less the same thing so I think,
we should merge it, then upgrade it as needed.

@GuillaumeSeren
Copy link
Collaborator Author

Ok let's merge it.

@GuillaumeSeren GuillaumeSeren merged commit f48d408 into afewmail:master Aug 1, 2017
@GuillaumeSeren GuillaumeSeren deleted the FolderNameFilter-manage-multiple-folder branch August 1, 2017 11:09
@GuillaumeSeren GuillaumeSeren mentioned this pull request Aug 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
enhancement use-case waiting-reply
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeSeren @varac @flokli @daewok