Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two new filters to propagate tags in threads #235

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Add two new filters to propagate tags in threads #235

merged 3 commits into from
Sep 18, 2019

Conversation

neuhalje
Copy link
Contributor

No description provided.

@GuillaumeSeren
Copy link
Collaborator

Hello @neuhalje,
thank you for this interresting patch, I think it could be merged, when passed the review (and rebased).

GuillaumeSeren
GuillaumeSeren approved these changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@GuillaumeSeren GuillaumeSeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuillaumeSeren
Copy link
Collaborator

@Floki @andir do you want to have a look ?

@GuillaumeSeren GuillaumeSeren requested review from flokli and andir May 28, 2019 11:40
@neuhalje
Copy link
Contributor Author

GitHub seems to have some kind of "auto merge" feature in PRs - tried that just now :-)

rpuntaie
rpuntaie suggested changes Aug 21, 2019
View reviewed changes
Copy link

@rpuntaie rpuntaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rst docstring, a double ` is needed to make an identifier literal.

@neuhalje
Copy link
Contributor Author

@rpuntaie - updated

@GuillaumeSeren
Copy link
Collaborator

Let's merge thank you for the patch @neuhalje

@GuillaumeSeren GuillaumeSeren merged commit 62a2de1 into afewmail:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpuntaie rpuntaie rpuntaie requested changes

@GuillaumeSeren GuillaumeSeren GuillaumeSeren approved these changes

@flokli flokli Awaiting requested review from flokli

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
enhancement reviewed use-case waiting-reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neuhalje @GuillaumeSeren @rpuntaie