Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: OAuth login with ORCID #154

Merged
merged 11 commits into from
Nov 24, 2021
Merged

ENH: OAuth login with ORCID #154

merged 11 commits into from
Nov 24, 2021

Conversation

tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Oct 27, 2021

Proposed changes

This PR adds the ability to log in to the AFIDs Validator (with an ORCID iD, using Flask-Dance), after which a user's ID will be associated with fiducial sets they submit for storage in the database.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@tkkuehn tkkuehn temporarily deployed to TEST October 27, 2021 17:06 Inactive
Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor things:

  • Update readme with new instructions for local testing
  • Update login button with orcid button
  • Fix some minor hiccups encountered when testing during meeting

@kaitj kaitj added the enhancement New feature or request label Oct 27, 2021
@tkkuehn tkkuehn changed the title Orcid login ENH: OAuth login with ORCID Oct 27, 2021
@tkkuehn
Copy link
Collaborator Author

tkkuehn commented Oct 27, 2021

@tkkuehn tkkuehn temporarily deployed to TEST November 1, 2021 14:17 Inactive
@tkkuehn tkkuehn requested a review from kaitj November 1, 2021 14:20
@kaitj
Copy link
Collaborator

kaitj commented Nov 1, 2021

Codewise this looks good to me. I am working through poetry to try to get the dependencies installed so I can test it again before merging.

One more recommendation is just to rebase from master / merge with master so that some of the files (eg. README) is updated.

@tkkuehn tkkuehn temporarily deployed to TEST November 1, 2021 20:56 Inactive
@kaitj kaitj temporarily deployed to TEST November 1, 2021 21:12 Inactive
@kaitj
Copy link
Collaborator

kaitj commented Nov 1, 2021

Mostly seems fine to me - is it possible to clarify the instructions for redirecting the urls within orcid.py? Eg. Adding the local testing URI (eg. localhost:<port> or 127.0.0.1:<port>) on the orcid side. Got stuck here for a minute. I added this into the README.

I also added in FLASK_APP to the .env.template file, otherwise it keeps asking for the missing variable.

Otherwise, looks good to merge to me. Maybe we can hold off on merging it until we've chatted about setting up a staging + production heroku app.

@kaitj kaitj temporarily deployed to TEST November 5, 2021 14:11 Inactive
@kaitj kaitj merged commit c1d1299 into master Nov 24, 2021
@kaitj kaitj deleted the orcid-login branch November 24, 2021 20:51
@kaitj kaitj temporarily deployed to TEST November 24, 2021 20:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants