-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: OAuth login with ORCID #154
Conversation
Can login (on the sandbox) but it doesn't do anything yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a few minor things:
- Update readme with new instructions for local testing
- Update login button with orcid button
- Fix some minor hiccups encountered when testing during meeting
Codewise this looks good to me. I am working through One more recommendation is just to rebase from master / merge with master so that some of the files (eg. |
I also added in Otherwise, looks good to merge to me. Maybe we can hold off on merging it until we've chatted about setting up a staging + production heroku app. |
Proposed changes
This PR adds the ability to log in to the AFIDs Validator (with an ORCID iD, using Flask-Dance), after which a user's ID will be associated with fiducial sets they submit for storage in the database.
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!black
with the-l 79
flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
PR template was adopted from appium