Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Split actions workflow between CI and Release #156

Merged
merged 10 commits into from
Nov 24, 2021
Merged

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Nov 5, 2021

Proposed changes

This splits the actions workflow into separate testing and release workflows. Additionally reverts releases to manual trigger, which was done to avoid those skip_changelog automatic version bumps.

PR also introduces separate heroku apps for testing and release. Production heroku app (the current afids-validator) will only be deployed on release. Otherwise, non-release merges that trigger the testing workflow will be deployed to a test heroku app (afids-validator-test).

There are probably some configs we need to set up for the afids-validator-test app

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

kaitj added 9 commits October 30, 2021 11:09
- ci workflow will always update the release draft, which will need to
be manually released
- when released, setup.py version is bumped and pushed back to master
- release also triggers heroku deployment
@kaitj kaitj added the maintenance Pull requests that maintain the repo label Nov 5, 2021
@kaitj kaitj temporarily deployed to TEST November 5, 2021 13:44 Inactive
@github-actions github-actions bot requested a review from tkkuehn November 5, 2021 13:46
@kaitj kaitj changed the title [Maint] Split actions workflow MAINT: Split actions workflow Nov 5, 2021
@kaitj kaitj changed the title MAINT: Split actions workflow MAINT: Split actions workflow between CI and Release Nov 5, 2021
@kaitj kaitj temporarily deployed to TEST November 8, 2021 17:45 Inactive
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Is the afids-validator-test heroku app already registered? If so, we can try merging this and getting the config right at the meeting on Wednesday.

@kaitj
Copy link
Collaborator Author

kaitj commented Nov 22, 2021

This looks good to me! Is the afids-validator-test heroku app already registered? If so, we can try merging this and getting the config right at the meeting on Wednesday.

I believe so. I had it already created, but hadn't set up any of the configs or anything like that yet (I don't think). Been a while though so would need to double check.

@tkkuehn tkkuehn merged commit 57b00b1 into master Nov 24, 2021
@tkkuehn tkkuehn deleted the actions_update branch November 24, 2021 20:06
@tkkuehn tkkuehn temporarily deployed to TEST November 24, 2021 20:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Pull requests that maintain the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants