-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Split actions workflow between CI and Release #156
Conversation
- ci workflow will always update the release draft, which will need to be manually released - when released, setup.py version is bumped and pushed back to master - release also triggers heroku deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Is the afids-validator-test
heroku app already registered? If so, we can try merging this and getting the config right at the meeting on Wednesday.
I believe so. I had it already created, but hadn't set up any of the configs or anything like that yet (I don't think). Been a while though so would need to double check. |
Proposed changes
This splits the actions workflow into separate testing and release workflows. Additionally reverts releases to manual trigger, which was done to avoid those
skip_changelog
automatic version bumps.PR also introduces separate heroku apps for testing and release. Production heroku app (the current
afids-validator
) will only be deployed on release. Otherwise, non-release merges that trigger the testing workflow will be deployed to a test heroku app (afids-validator-test
).There are probably some configs we need to set up for the
afids-validator-test
appTypes of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!black
with the-l 79
flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
PR template was adopted from appium