Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes #164

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Remove quotes #164

merged 1 commit into from
Nov 24, 2021

Conversation

tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Nov 24, 2021

Proposed changes

Describe the changes implemented in this pull request. If the changes fix a bug or resolves a feature request, be sure to link the issue. Please explain the issue and how the changes address the issue.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@tkkuehn tkkuehn temporarily deployed to TEST November 24, 2021 21:58 Inactive
@tkkuehn tkkuehn requested a review from kaitj November 24, 2021 21:58
@kaitj
Copy link
Collaborator

kaitj commented Nov 24, 2021

still lgtm, hopefully this fixes our deploy issues!

@kaitj kaitj merged commit 709b5d4 into master Nov 24, 2021
@kaitj kaitj deleted the fix-release-2 branch November 24, 2021 22:01
@kaitj kaitj temporarily deployed to TEST November 24, 2021 22:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants