Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Release patch fix #165

Merged
merged 7 commits into from
Nov 26, 2021
Merged

BUG: Release patch fix #165

merged 7 commits into from
Nov 26, 2021

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Nov 25, 2021

Proposed changes

Did some testing this morning to try to get the release version update working. Decided to simplify the workflows a little now that we have 2 apps (test and prod).

CI workflow will now only update the changelog upon deployment afids-validator-test. Deployment to test will cause an update to the version in setup.py to be updated as necessary. This means that the master branch will always have the newest tag and may not match the version deployed to the production afids-validator.

Release workflow uses github.ref to grab the latest release tag, and pushes the released version to production afids-validator.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

- update draft of changelog whenever test deployment occurs
- at this time update, the version located in setup.py in master branch (as needed)
- deploy to test app
- once merged, grab latest tag and deploy to heroku
@kaitj kaitj temporarily deployed to TEST November 25, 2021 15:12 Inactive
@github-actions github-actions bot requested a review from tkkuehn November 25, 2021 15:14
@kaitj kaitj added the bug Something isn't working label Nov 25, 2021
@kaitj kaitj changed the title BUG: Release patch 3 BUG: Release patch fix Nov 25, 2021
@kaitj kaitj temporarily deployed to TEST November 26, 2021 14:24 Inactive
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkkuehn tkkuehn merged commit baea036 into master Nov 26, 2021
@tkkuehn tkkuehn deleted the release-patch-3 branch November 26, 2021 15:12
@tkkuehn tkkuehn temporarily deployed to TEST November 26, 2021 15:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants