Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bump Version #174

Merged
merged 1 commit into from
May 18, 2022
Merged

Fix Bump Version #174

merged 1 commit into from
May 18, 2022

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented May 6, 2022

Proposed changes

Fixes a bug with github action causing deployment to fail. Instead of checking for and replacing punctuation in the search and replace, just searches for version numbers (including *-pre.*). This change also reverts the release version back to v1.2.2-pre.1 prior to the deployment workflow breaking.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@kaitj kaitj added the bug Something isn't working label May 6, 2022
@kaitj kaitj temporarily deployed to TEST May 6, 2022 18:34 Inactive
- Replaces search and replace to search up to number, but no punctuation
- Revert to v1.2.2-pre.1
@kaitj kaitj temporarily deployed to TEST May 6, 2022 18:38 Inactive
@github-actions github-actions bot requested a review from tkkuehn May 6, 2022 18:40
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My regular expressions are a bit rusty, but the .+ at the end of the first option of the find regular expression worries me (i.e. would this just wipe the end of the file?). Could we make it a bit more specific, maybe something like v[0-9]+\.[0-9]+\.[0-9]+(?:-pre.[0-9]+)??

It's possible that I'm just off base though so feel free to correct me.

@kaitj
Copy link
Collaborator Author

kaitj commented May 12, 2022

Hmm, you might be right about the regex - I haven't tested this on this repo since the change and was just copied over from the snakebids repo (yay github actions testing). There are some noted differences in the two repos, but I think it should work? Might be best to either test this on a fork or if we have some time to sit down and try to fix this live.

@tkkuehn
Copy link
Collaborator

tkkuehn commented May 18, 2022

Just going to give this a shot and roll it back if it breaks

@tkkuehn tkkuehn merged commit 2b4eb04 into master May 18, 2022
@tkkuehn tkkuehn deleted the fix_actions branch May 18, 2022 20:58
@tkkuehn tkkuehn temporarily deployed to TEST May 18, 2022 20:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants