Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort templates in list #177

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Sort templates in list #177

merged 2 commits into from
Aug 19, 2022

Conversation

tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Aug 19, 2022

Proposed changes

Sort human templates

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@tkkuehn tkkuehn requested a review from kaitj August 19, 2022 17:00
@tkkuehn tkkuehn temporarily deployed to TEST August 19, 2022 17:00 Inactive
@tkkuehn
Copy link
Collaborator Author

tkkuehn commented Aug 19, 2022

Feel free to merge if this looks good

Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitj kaitj merged commit dba47d8 into master Aug 19, 2022
@kaitj kaitj deleted the sort-templates branch August 19, 2022 17:18
@kaitj kaitj temporarily deployed to TEST August 19, 2022 17:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants