Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Docker compose #185

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Set up Docker compose #185

merged 1 commit into from
Oct 21, 2022

Conversation

tkkuehn
Copy link
Collaborator

@tkkuehn tkkuehn commented Oct 19, 2022

Proposed changes

Write a Dockerfile and compose.yml to set up a test environment in Docker. This involved a couple of relatively small code changes to the Validator to work properly.

To try it out:

  • Install docker-compose
  • docker compose up --build
  • In a separate tab, export DATABASE_URL=postgresql+psycopg2://postgres:[email protected]:5432 && poetry run flask db upgrade
  • Navigate to http://127.0.0.1:5001

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@tkkuehn tkkuehn temporarily deployed to TEST October 19, 2022 18:30 Inactive
@tkkuehn tkkuehn temporarily deployed to TEST October 19, 2022 18:30 Inactive
@tkkuehn tkkuehn temporarily deployed to TEST October 19, 2022 18:30 Inactive
Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tkkuehn tkkuehn merged commit fc57237 into master Oct 21, 2022
@tkkuehn tkkuehn deleted the docker branch October 21, 2022 13:06
@tkkuehn tkkuehn temporarily deployed to TEST October 21, 2022 13:06 Inactive
@tkkuehn tkkuehn temporarily deployed to TEST October 21, 2022 13:06 Inactive
@tkkuehn tkkuehn temporarily deployed to TEST October 21, 2022 13:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants