Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert werkzeug dependency to >=2.3, <3.0 #224

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Oct 25, 2023

Proposed changes

Latest major bump of werkzeug removed some functionality that has caused compatibility issues with Flask-Login. This commit implements a patch-fix reverting werkzeug back to 2.3.x.

Long-term, will want to look to upgrade to Flask 3.0, which resolves some of these issues.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@kaitj kaitj added the bug Something isn't working label Oct 25, 2023
Latest major bump of werkzeug removed some functionality that has caused
compatibility issues with Flask-Login. This commit implements a
patch-fix reverting werkzeug back to 2.3.x.

Long-term, will want to look to upgrade to Flask 3.0, which resolves
some of these issues.
@kaitj
Copy link
Collaborator Author

kaitj commented Oct 25, 2023

Action workflow error is caused by upstream issue in the reusable actions repository. Merging this in as is.

@kaitj kaitj merged commit 73bd904 into afids:master Oct 25, 2023
4 of 7 checks passed
@kaitj kaitj deleted the bug/werkzeug branch October 25, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant