Update dependencies #229
Merged
Update dependencies #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all dependencies to latest versions
Make the __init__.py and config more concise with appropriate Flask variables. There was a lot of duplication of code from the config object being read and in the initialization under `create_app`. Also removed heroku-related code in these two files as app is no longer hosted on heroku. Additionally updated the .env.template to reflect changes from the code.
Instead of hard coding the variables into the compose.yml file, the only variable still hard-coded is the uwsgi socket. Everything else is read from the .env file (which the user will have to copy from the .envtemplate and set variables accordingly).
Old instructions for testing development was outdated, referring to a now obsolete `manage.py` file. This commit updates this, referring the user to make use of docker compose for testing, which is the easiest way, albeit at the cost of additional installations. The benefit of this is the user does not need to separately install and setup Postgres. However, this also means to test each change, the user will have to run a separate `docker compose up --build`.
Instead of using flake8 and pylint (+ plugins), this commit makes the switch to Ruff. Pylint was having internal issues that could not be disabled. Ruff is a rust-based linter / formatter we have been using in other projects, so this seemed like a good time to make the switch.
kaitj
force-pushed
the
maint/update-flask
branch
from
875cdd6 to
2d01e12
Compare
|
Merging this one in despite the CI workflow failing - for some reason it is still using the old linting checks. I have run these locally to make sure the pass |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #225. A number of our dependencies were outdated, one of which caused a conflict when trying to bump via dependabot. This PR just goes through and updates all of the dependencies.
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!blackwith the-l 79flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
PR template was adopted from appium