Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes #233

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Various bug fixes #233

merged 3 commits into from
Nov 22, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Nov 22, 2023

Proposed changes

A PR to fix a few bugs:

  • Banner not loading in the README
  • Checkout reference branch instead of main branch for deployment.
  • Attempt to fix intermittent JS loading in production

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@kaitj kaitj added the bug Something isn't working label Nov 22, 2023
@kaitj kaitj self-assigned this Nov 22, 2023
@kaitj kaitj changed the title Maint/bug fixes Various bug fixes Nov 22, 2023
This was linked to issues Nov 22, 2023
@kaitj kaitj merged commit 235cae6 into afids:master Nov 22, 2023
9 checks passed
@kaitj kaitj deleted the maint/bug-fixes branch November 22, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deploy workflow Fix README banner
1 participant