eliminate need to mock HTMLElement in node

src/core/a-cubemap.js

@@ -1,4 +1,3 @@
-/* global HTMLElement */
 var debug = require('../utils/debug');
 var registerElement = require('./a-register-element').registerElement;
 
@@ -9,7 +8,7 @@ var warn = debug('core:cubemap:warn');
  * Does not listen to updates.
  */
 module.exports = registerElement('a-cubemap', {
-  prototype: Object.create(HTMLElement.prototype, {
+  prototype: Object.create(window.HTMLElement.prototype, {
     /**
      * Calculates this.srcs.
      */

src/core/a-entity.js

@@ -1,4 +1,3 @@
-/* global HTMLElement */
 var ANode = require('./a-node');
 var COMPONENTS = require('./component').components;
 var registerElement = require('./a-register-element').registerElement;
@@ -384,7 +383,7 @@ var proto = Object.create(ANode.prototype, {
       // the component with the empty string.
       if (!this.hasAttribute(attrName)) {
         component.justInitialized = true;
-        HTMLElement.prototype.setAttribute.call(this, attrName, '');
+        window.HTMLElement.prototype.setAttribute.call(this, attrName, '');
       }
 
       debug('Component initialized: %s', attrName);
@@ -416,7 +415,7 @@ var proto = Object.create(ANode.prototype, {
         // Call getAttribute to initialize the data from the DOM.
         self.initComponent(
           componentName,
-          HTMLElement.prototype.getAttribute.call(self, componentName) || undefined,
+          window.HTMLElement.prototype.getAttribute.call(self, componentName) || undefined,
           true
         );
       });
@@ -580,7 +579,7 @@ var proto = Object.create(ANode.prototype, {
         this.mixinUpdate('');
       }
 
-      HTMLElement.prototype.removeAttribute.call(this, attr);
+      window.HTMLElement.prototype.removeAttribute.call(this, attr);
     }
   },
 
@@ -701,7 +700,7 @@ var proto = Object.create(ANode.prototype, {
       // Initialize component first if not yet initialized.
       if (!this.components[attrName] && this.hasAttribute(attrName)) {
         this.updateComponent(attrName,
-                             HTMLElement.prototype.getAttribute.call(this, attrName));
+                             window.HTMLElement.prototype.getAttribute.call(this, attrName));
       }
 
       // Determine which type of setAttribute to call based on the types of the arguments.
@@ -779,7 +778,7 @@ var proto = Object.create(ANode.prototype, {
       // If component, return component data.
       var component = this.components[attr];
       if (component) { return component.data; }
-      return HTMLElement.prototype.getAttribute.call(this, attr);
+      return window.HTMLElement.prototype.getAttribute.call(this, attr);
     },
     writable: window.debug
   },
@@ -813,7 +812,7 @@ var proto = Object.create(ANode.prototype, {
       // If cached value exists, return partial component data.
       var component = this.components[attr];
       if (component) { return component.attrValue; }
-      return HTMLElement.prototype.getAttribute.call(this, attr);
+      return window.HTMLElement.prototype.getAttribute.call(this, attr);
     },
     writable: window.debug
   },

src/core/a-mixin.js

@@ -1,4 +1,3 @@
-/* global HTMLElement */
 var ANode = require('./a-node');
 var registerElement = require('./a-register-element').registerElement;
 var components = require('./component').components;
@@ -39,7 +38,7 @@ module.exports = registerElement('a-mixin', {
     setAttribute: {
       value: function (attr, value) {
         this.cacheAttribute(attr, value);
-        HTMLElement.prototype.setAttribute.call(this, attr, value);
+        window.HTMLElement.prototype.setAttribute.call(this, attr, value);
       }
     },
 
@@ -52,7 +51,7 @@ module.exports = registerElement('a-mixin', {
         var component = components[componentName];
         if (!component) { return; }
         if (value === undefined) {
-          value = HTMLElement.prototype.getAttribute.call(this, attr);
+          value = window.HTMLElement.prototype.getAttribute.call(this, attr);
         }
         this.componentCache[attr] = component.parseAttrValueForCache(value);
       }
@@ -65,7 +64,7 @@ module.exports = registerElement('a-mixin', {
     getAttribute: {
       value: function (attr) {
         return this.componentCache[attr] ||
-               HTMLElement.prototype.getAttribute.call(this, attr);
+               window.HTMLElement.prototype.getAttribute.call(this, attr);
       }
     },
 

src/core/a-node.js

@@ -1,4 +1,4 @@
-/* global HTMLElement, MutationObserver */
+/* global MutationObserver */
 var registerElement = require('./a-register-element').registerElement;
 var utils = require('../utils/');
 
@@ -12,7 +12,7 @@ var warn = utils.debug('core:a-node:warn');
  * Nodes emit a `loaded` event when they and their children have initialized.
  */
 module.exports = registerElement('a-node', {
-  prototype: Object.create(HTMLElement.prototype, {
+  prototype: Object.create(window.HTMLElement.prototype, {
     createdCallback: {
       value: function () {
         this.hasLoaded = false;
@@ -160,7 +160,7 @@ module.exports = registerElement('a-node', {
     setAttribute: {
       value: function (attr, newValue) {
         if (attr === 'mixin') { this.updateMixins(newValue); }
-        HTMLElement.prototype.setAttribute.call(this, attr, newValue);
+        window.HTMLElement.prototype.setAttribute.call(this, attr, newValue);
       }
     },
 

src/core/component.js

@@ -1,4 +1,4 @@
-/* global HTMLElement, Node */
+/* global Node */
 var schema = require('./schema');
 var scenes = require('./scene/scenes');
 var systems = require('./system');
@@ -214,7 +214,7 @@ Component.prototype = {
   flushToDOM: function (isDefault) {
     var attrValue = isDefault ? this.data : this.attrValue;
     if (!attrValue) { return; }
-    HTMLElement.prototype.setAttribute.call(this.el, this.attrName,
+    window.HTMLElement.prototype.setAttribute.call(this.el, this.attrName,
                                             this.stringify(attrValue));
   },
 

src/core/system.js

@@ -1,4 +1,3 @@
-/* global HTMLElement */
 var components = require('./component');
 var schema = require('./schema');
 var utils = require('../utils/');
@@ -80,7 +79,7 @@ System.prototype = {
   buildData: function (rawData) {
     var schema = this.schema;
     if (!Object.keys(schema).length) { return; }
-    rawData = rawData || HTMLElement.prototype.getAttribute.call(this.sceneEl, this.name);
+    rawData = rawData || window.HTMLElement.prototype.getAttribute.call(this.sceneEl, this.name);
     if (isSingleProp(schema)) {
       this.data = parseProperty(rawData, schema);
     } else {

tests/node/test.js

@@ -10,14 +10,12 @@ suite('node acceptance tests', function () {
     let _window = global.window = jsdom.jsdom().defaultView;
     global.navigator = _window.navigator;
     global.document = _window.document;
-    global.HTMLElement = _window.HTMLElement;
   });
 
   teardown(function () {
     delete global.window;
     delete global.navigator;
     delete global.document;
-    delete global.HTMLElement;
   });
 
   test('can run in node', function () {