Update initial camera query (fix #5023) #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
changed the title
dmarcos
reviewed
Mar 13, 2022
| @@ -43,7 +43,7 @@ module.exports.System = registerSystem('camera', { | |||
| } | |||
|
|
|||
| // Search for initial user-defined camera. | |||
| cameraEls = sceneEl.querySelectorAll('a-camera, [camera]'); | |||
| cameraEls = sceneEl.querySelectorAll('a-camera, :not(a-mixin)[camera]'); | |||
There was a problem hiding this comment.
Really nice and simple. Great work. Thanks so much.
|
I think there are other querySelectors for the camera that we should also take care of: https://github.com/aframevr/aframe/blob/master/src/systems/camera.js#L135 https://github.com/aframevr/aframe/blob/master/src/systems/camera.js#L161 https://github.com/aframevr/aframe/blob/master/src/systems/camera.js#L178 |
|
I updated the PR to address the additional |
|
Thanks so much. Great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Resolves #5023.
There are additional
[camera]queries incamera.jsthat may need to be updated too, but for now I only changed the one that fixes the perpetual loading screen from the linked issue (verified inexamples/test/mixin/index.html)Changes proposed:
[camera]->:not(a-mixin)[camera]