Update web translation files #1780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Agama-weblate commit: 3cb793a92ee506d70aa32d3932230e89a6dd18f0
github-actions
bot
added
translations
|
This was just a testing run for verifying that the updated GitHub Action works fine. Related to #1777 |
4 tasks
lslezak
added a commit
that referenced
this pull request
Nov 28, 2024
## Problem - The web translations still use the original Cockpit mechanism for creating and loading the translations - That uses a server based logic which has quite some drawbacks - We have to reimplement the very same logic in a Webpack plugin to make it work also in the local development server (`npm run server`). And unfortunately we cannot share the code because it is Rust vs. Javascript... - This will not work in the Agama online demo site with completely static files (without any server side logic, everything needs to be on the client side). - For me the original logic was quite strange, why the server should decide which translations should the client use? It should be completely handled on the client side, there is no reason for the special server logic. The server should just report the available translations and let the client to pick and use the right one. - The old implementation has also some ugly parts like requiring a global Javascript variable... ## Solution - Move the translation logic from the server to the client (browser) - Use dynamic imports instead of HTTP redirection ## Implementation details - Removed the `po.js` handler from the Agama HTTP server - Removed the `po.js` handler from the Webpack development server - Removed the original Gettext PO files from Git, replaced by already converted JS files - Removed the Cockpit Webpack plugin for converting PO files to JS, replaced by a simple script with similar functionality. (As a bonus the code was fixed to avoid adding unnecessary `null` values into the output.) - Added dynamic import for downloading the requested translations - Some code cleanup (removing the global JS object) - Moved the `jed` and `gettext-parser` NPM dependencies to the PO->JS converter, that means those NPM packages are installed only when converting the PO files to JS (basically only in the GitHub action which merges them), they are not installed when building the Agama web frontend ## Testing - Tested manually, loading the translations works fine - I manually triggered the GitHub Action which merges the translations from Weblate. It works fine, the test run opened this [pull request](#1780) with updated translations (there are more changes as it was executed in the same branch as this pull request).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the web translation files from the agama-weblate repository