Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add option to reset storage config #1986

Draft
wants to merge 22 commits into
base: storage-config-ui
Choose a base branch
from

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Feb 11, 2025

Add Reset to defaults option into the More options menu.

@joseivanlopez joseivanlopez force-pushed the storage-reset-config branch 2 times, most recently from 06826d5 to f2ae3c6 Compare February 11, 2025 12:54
@joseivanlopez
Copy link
Contributor Author

Screenshot From 2025-02-11 12-55-57

@joseivanlopez joseivanlopez changed the title feat(web): add reset to defaults option feat(web): add option to reset storage config Feb 11, 2025
@joseivanlopez joseivanlopez force-pushed the storage-reset-config branch 2 times, most recently from 7346087 to 69d1ee9 Compare February 13, 2025 07:01
@ancorgs
Copy link
Contributor

ancorgs commented Feb 14, 2025

I would take this as an opportunity to clean-up/reorganize "more options". Let's say:

  • Change boot options
  • Reset to default configuration
  • [Separator]
  • Configure iSCSI
  • [s390 stuff (with their current titles)]

@dgdavid
Copy link
Contributor

dgdavid commented Feb 14, 2025

I would take this as an opportunity to clean-up/reorganize "more options". Let's say:

  • Change boot options
  • Reset to default configuration
  • [Separator]
  • Configure iSCSI
  • [s390 stuff (with their current titles)]

Excuse my ignorance, but what about LVM and RAID options? Part of "Use additional disk"?

@ancorgs
Copy link
Contributor

ancorgs commented Feb 14, 2025

Excuse my ignorance, but what about LVM and RAID options? Part of "Use additional disk"?

No. They will be here... but we have not implemented any UI for them yet. :-(

@dgdavid
Copy link
Contributor

dgdavid commented Feb 14, 2025

No. They will be here... but we have not implemented any UI for them yet. :-(

Ah, right. So, the idea is to remove them by now and decide later their place, isn't it?

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13332363290

Details

  • 14 of 18 (77.78%) changed or added relevant lines in 4 files are covered.
  • 186 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+15.1%) to 87.526%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/dbus/storage/manager.rb 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
service/service/lib/agama/storage/manager.rb 2 97.22%
service/service/lib/agama/storage/proposal.rb 3 97.78%
service/lib/agama/autoyast/connections_reader.rb 4 93.75%
service/service/lib/agama/autoyast/connections_reader.rb 4 93.75%
service/lib/agama/software/callbacks/progress.rb 15 66.67%
service/service/lib/agama/software/callbacks/progress.rb 15 66.67%
service/service/lib/agama/dbus/storage/manager.rb 43 75.92%
service/lib/agama/software/manager.rb 50 75.16%
service/service/lib/agama/software/manager.rb 50 75.16%
Totals Coverage Status
Change from base Build 13305098023: 15.1%
Covered Lines: 6694
Relevant Lines: 7648

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants