Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoOne functionality update for Agda v2.7.0 and up #156

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

iwashis
Copy link
Contributor

@iwashis iwashis commented Oct 8, 2024

With version 2.7.0 of Agda and the introduction of mimer (instead of agsy) for auto mode, Cmd_autoOne comes with arguments:

  -- | Solve (all goals / the goal at point) by using Mimer proof search.
    | Cmd_autoOne  Rewrite   InteractionId range String

(see https://github.com/agda/agda/blob/11e54c0e0229996c22ed7b53a50694933de84b09/src/full/Agda/Interaction/Base.hs#L174 for reference). This is an inconsitency between agda and cornelis types for interaction and brakes cornelis command :CornelisAuto which throws an error.

The proposed change to the repository fixes the issue and creates type consistency between cornelis and agda Interaction datatype.

@isovector
Copy link
Collaborator

Looks very reasonable, thanks! Let's see what CI says

@iwashis
Copy link
Contributor Author

iwashis commented Oct 24, 2024

@isovector Thanks! All checks have passed, so I guess the change is good to go.

@isovector isovector merged commit 41b7d5e into agda:master Oct 24, 2024
16 checks passed
@isovector
Copy link
Collaborator

Thanks for the PR (and the reminder)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants