Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing customization of the center frequency and of material layers #82

Merged
merged 19 commits into from
Jul 17, 2023

Conversation

NewtonSander
Copy link
Collaborator

This PR allows the configuration of center frequency and also makes it much more simpler to customize the material layers of a simulation

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.43 🎉

Comparison is base (aea64a0) 72.95% compared to head (22d8426) 73.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   72.95%   73.38%   +0.43%     
==========================================
  Files          27       27              
  Lines        2052     2033      -19     
==========================================
- Hits         1497     1492       -5     
+ Misses        555      541      -14     
Impacted Files Coverage Δ
src/neurotechdevkit/rendering/napari.py 33.33% <ø> (+0.52%) ⬆️
src/neurotechdevkit/results/_metrics.py 100.00% <ø> (ø)
src/neurotechdevkit/scenarios/_scenario_2.py 48.05% <68.75%> (-2.49%) ⬇️
src/neurotechdevkit/scenarios/_base.py 79.74% <92.30%> (+1.78%) ⬆️
src/neurotechdevkit/materials.py 95.23% <95.23%> (ø)
src/neurotechdevkit/__init__.py 92.85% <100.00%> (ø)
src/neurotechdevkit/results/_results.py 59.18% <100.00%> (+0.13%) ⬆️
src/neurotechdevkit/scenarios/__init__.py 100.00% <100.00%> (ø)
src/neurotechdevkit/scenarios/_scenario_0.py 97.36% <100.00%> (-0.10%) ⬇️
src/neurotechdevkit/scenarios/_scenario_1.py 90.00% <100.00%> (+3.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NewtonSander NewtonSander force-pushed the making_center_frequency_customizable branch from 97f4c01 to 91380a4 Compare June 22, 2023 16:33
@NewtonSander NewtonSander force-pushed the making_center_frequency_customizable branch from 91380a4 to ac64c78 Compare June 22, 2023 16:39
@NewtonSander NewtonSander requested a review from d-lucena June 22, 2023 16:42
@NewtonSander NewtonSander force-pushed the making_center_frequency_customizable branch from 8a55990 to f747f3e Compare June 22, 2023 16:52
src/neurotechdevkit/materials.py Outdated Show resolved Hide resolved
docs/examples/plot_customized_center_frequency.py Outdated Show resolved Hide resolved
src/neurotechdevkit/materials.py Outdated Show resolved Hide resolved
src/neurotechdevkit/materials.py Outdated Show resolved Hide resolved
src/neurotechdevkit/materials.py Outdated Show resolved Hide resolved
@NewtonSander NewtonSander requested a review from d-lucena July 5, 2023 12:41
@NewtonSander NewtonSander merged commit 79f9eda into main Jul 17, 2023
@NewtonSander NewtonSander deleted the making_center_frequency_customizable branch July 17, 2023 05:54
NewtonSander added a commit that referenced this pull request Jul 26, 2024
…#82)

* Allowing customization of the center frequency and of material layers

* Removing docstring mentions of the fixed 500kHz frequency

* Making materials dynamic, allowing the absorption calculation based on center frequency

* Adding algorithm to calculate the material absorption based on the frequency

* Defining fixed material properties to the scenarios to match the paper

---------

Co-authored-by: Diogo de Lucena <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants