IE-40 + index.ts: modified the require statement at end of file. Unsa… #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspasojevic
reviewed
Oct 12, 2022
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
| const command = require(path); | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access | ||
| return (typeof command === 'object' ? command.default : command)(rootCommand); |
There was a problem hiding this comment.
Maybe this unsafe convenience has aged out and should be replaced with explicit imports?
There was a problem hiding this comment.
There is an option of using a dynamic import. It sorta fixes the problem. It does have typing on the return value from the import import("./somePath"). The types turn to any when you're using a string like we are instead of a string const. The advantage that import gives us regardless is it will always be an object. Even with cast from any to a module, we could do ((await import(path)) as {default: FuncType}).default(rootCommand)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.