Remove on suspend option #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the hosts entries where removed when the VMs are suspended, but not added again when you called resume. With this patch the hosts entries are only removed when you set the remove_on_suspend option to true, and they are always added again when you call resume.
Fixed code blocks
|
This looks awesome! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all thanks for this plugin, I was looking for a solution to manage the host entries, and so far it seems to work very good.
I found one issue so far: When you call
vagrant suspendthe host entries are removed, but when callingvagrant resumethey are not added again.So I made some little changes to fix this, please consider pulling them:
vagrant suspendvagrant resume