[WIP] Cache / Download Images #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use react-native-expo-image-cache, which just caches all images used
by its component in temp storage
- not quite like local storage persist: doesn't have a way to purge
and just caches all images, not specific ones chosen or from
favorites or anything
- will have to make modifications later so it works like other manga
apps where you can click a download button for specific manga
- had to fork it as it hasn't been updated in a while and performs a
build on postinstall instead of during packaging
- still getting a bug on missing '@babel/runtime'. not sure if this
is required in Babel 7 now (post beta)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still getting bugs with
react-native-expo-image-cache, even on my fork. Might be a Babel 7 thing.This is still not ideal as caching is a bit different than the standard reader app functionality of "download / save for later". Long-term storage and unnecessary storage are issues. The other issue is that at least some sites have signed/timestamped images; if they're cached, they won't expire by timestamp of course, but retrieving the image might not hit the cache.
This likely needs a more custom solution with
FilesystemStorage, which would be way more effort. The timestamp concerns and general restructuring of how pages/images are retrieved also requires more integrations with different sites to see how different ones do it.