Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] TS: support conversion from any to DbValue #1096 #1094

Merged
merged 7 commits into from
May 20, 2024

Conversation

pinghe
Copy link
Contributor

@pinghe pinghe commented May 13, 2024

Corrected the error in InsertBuilder.elements and added an elementsAliases method to facilitate node insertion based on alias.

Corrected the error in InsertBuilder.elements and added an elementsAliases method to facilitate node insertion based on alias.
@michaelvlach michaelvlach changed the title Update query_builder.ts [api] TS: any to DbValue May 14, 2024
@michaelvlach michaelvlach changed the title [api] TS: any to DbValue [api] TS: support conversion from any to DbValue #1096 May 14, 2024
@michaelvlach
Copy link
Collaborator

michaelvlach commented May 14, 2024

Corrected the error in InsertBuilder.elements and added an elementsAliases method to facilitate node insertion based on alias.

The insert of elements with alias is not directly supported in the Rust's QueryBuilder although it is technically supported by manipulating the query object directly. I can see the use case and I will add it as an enhancement but it would need to come to all API versions (Rust & TS being the only ones now) and not just to the TS version.

Would you mind to focus this PR to the DbValue conversion? I would add the support for the aliases with the insertion of elements in separate issue (#1098) & PR. Thanks!

@pinghe
Copy link
Contributor Author

pinghe commented May 15, 2024

OK

Corrected the error in InsertBuilder.elements
michaelvlach
michaelvlach previously approved these changes May 15, 2024
@michaelvlach michaelvlach enabled auto-merge (squash) May 15, 2024 17:41
Correct the 'multiItem' is not defined error
auto-merge was automatically disabled May 16, 2024 04:16

Head branch was pushed to by a user without write access

michaelvlach
michaelvlach previously approved these changes May 16, 2024
@michaelvlach michaelvlach enabled auto-merge (squash) May 16, 2024 05:09
auto-merge was automatically disabled May 20, 2024 14:53

Head branch was pushed to by a user without write access

@michaelvlach michaelvlach enabled auto-merge (squash) May 20, 2024 16:35
@michaelvlach michaelvlach merged commit 48b3354 into agnesoft:main May 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants