Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lance-db-name_exists-ag-2655 #2024

Merged
merged 4 commits into from
Feb 6, 2025
Merged

lance-db-name_exists-ag-2655 #2024

merged 4 commits into from
Feb 6, 2025

Conversation

ysolanky
Copy link
Contributor

@ysolanky ysolanky commented Feb 5, 2025

Description

  • Added name_exists function for LanceDb.

Fixes #2017


Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update (Addition or modification of models)
  • Other (please describe):

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

LanceDb natively does not allow name_exists. This is a very inefficient workaround. To be updated when native search for a doc name is added by LanceDb. name_exists is used by the WebsiteKnowledgeBase

@ysolanky ysolanky requested a review from a team as a code owner February 5, 2025 20:41
@ysolanky ysolanky mentioned this pull request Feb 5, 2025
@ysolanky ysolanky changed the title Lance db name exists ag 2655 lance-db-name_exists-ag-2655 Feb 5, 2025
@ysolanky ysolanky merged commit eafa0e4 into main Feb 6, 2025
1 check passed
@ysolanky ysolanky deleted the lance-db-name_exists-ag-2655 branch February 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]
2 participants