executor: refactoring to avoid locking during setupTask

internal/services/executor/executor.go

@@ -758,7 +758,9 @@ func (e *Executor) executeTask(rt *runningTask) {
 		e.log.Err(err).Send()
 	}
 
+	rt.Unlock()
 	if err := e.setupTask(ctx, rt); err != nil {
+		rt.Lock()
 		e.log.Err(err).Send()
 		et.Status.Phase = types.ExecutorTaskPhaseFailed
 		et.Status.EndTime = util.TimeP(time.Now())
@@ -767,10 +769,10 @@ func (e *Executor) executeTask(rt *runningTask) {
 		if err := e.sendExecutorTaskStatus(ctx, et); err != nil {
 			e.log.Err(err).Send()
 		}
-		rt.Unlock()
 		return
 	}
 
+	rt.Lock()
 	et.Status.SetupStep.Phase = types.ExecutorTaskPhaseSuccess
 	et.Status.SetupStep.EndTime = util.TimeP(time.Now())
 	if err := e.sendExecutorTaskStatus(ctx, et); err != nil {
@@ -905,6 +907,7 @@ func (e *Executor) setupTask(ctx context.Context, rt *runningTask) error {
 func (e *Executor) executeTaskSteps(ctx context.Context, rt *runningTask, pod driver.Pod) (int, error) {
 	for i, step := range rt.et.Spec.Steps {
 		rt.Lock()
+
 		rt.et.Status.Steps[i].Phase = types.ExecutorTaskPhaseRunning
 		rt.et.Status.Steps[i].StartTime = util.TimeP(time.Now())
 		if err := e.sendExecutorTaskStatus(ctx, rt.et); err != nil {
@@ -951,6 +954,7 @@ func (e *Executor) executeTaskSteps(ctx context.Context, rt *runningTask, pod dr
 		var serr error
 
 		rt.Lock()
+
 		rt.et.Status.Steps[i].EndTime = util.TimeP(time.Now())
 
 		rt.et.Status.Steps[i].Phase = types.ExecutorTaskPhaseSuccess
@@ -1071,6 +1075,7 @@ func (e *Executor) executorTasksStatusSenderLoop(ctx context.Context) {
 			}
 
 			rt.Lock()
+
 			if err := e.sendExecutorTaskStatus(ctx, rt.et); err != nil {
 				e.log.Err(err).Send()
 				rt.Unlock()