Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: mount multiple volumes #142

Merged
merged 1 commit into from
Oct 17, 2019
Merged

docker: mount multiple volumes #142

merged 1 commit into from
Oct 17, 2019

Conversation

camandel
Copy link
Contributor

If a container, managed by docker driver, was configured to mount more than one volume:

volumes:
  - path: /mnt/vol1
    tmpfs:
      size: 1Gi
  - path: /mnt/vol2
    tmpfs:
      size: 512Mi

the result was that only the last one (in this case /mnt/vol2) was correctly mounted.

sgotti
sgotti requested changes Oct 16, 2019
View reviewed changes
Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camandel Good Catch! Some comments inline.

internal/services/executor/driver/docker_test.go Outdated Show resolved Hide resolved
internal/services/executor/driver/docker_test.go Show resolved Hide resolved
@camandel camandel force-pushed the fix_multiple_volumes branch from 8c2d215 to 6fccb93 Compare October 17, 2019 07:23
@sgotti
Copy link
Member

sgotti commented Oct 17, 2019

@camandel LGTM. Merging. Thanks!

@sgotti sgotti merged commit fc283e7 into agola-io:master Oct 17, 2019
@camandel camandel deleted the fix_multiple_volumes branch October 29, 2019 10:34
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
@sgotti
Merge pull request agola-io#142 from camandel/fix_multiple_volumes
fa10064 
docker: mount multiple volumes
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
@sgotti
Merge pull request agola-io#142 from camandel/fix_multiple_volumes
dc9915c 
docker: mount multiple volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgotti sgotti sgotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camandel @sgotti