Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run config: add tty option for run steps #149

Merged
merged 1 commit into from
Oct 29, 2019
Merged

run config: add tty option for run steps #149

merged 1 commit into from
Oct 29, 2019

Conversation

camandel
Copy link
Contributor

A try to fix issue #1 adding "tty" option for run steps (default is true):

- run:
    name: test tty
    command: "ps -ef && lsof"
    tty: false

sgotti
sgotti requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camandel Thanks for the PR.

Some comments inline. Also tests are failing and should be updated.

services/runservice/types/types.go Outdated Show resolved Hide resolved
@sgotti
Copy link
Member

sgotti commented Oct 28, 2019

@camandel Is this ready for review? Can you please rebase on current master? Thanks.

@camandel
Copy link
Contributor Author

@sgotti Rebase done.

@sgotti
Copy link
Member

sgotti commented Oct 29, 2019

@camandel LGTM. Merging. Thanks!

@sgotti sgotti merged commit ec67b26 into agola-io:master Oct 29, 2019
@camandel camandel deleted the add_tty_option branch November 6, 2019 09:02
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
@sgotti
Merge pull request agola-io#149 from camandel/add_tty_option
a8863fa 
run config: add tty option for run steps
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
@sgotti
Merge pull request agola-io#149 from camandel/add_tty_option
bd6d8d2 
run config: add tty option for run steps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgotti sgotti sgotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camandel @sgotti