cmd: project option to disable passing variables to PR from forked repo #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camandel
force-pushed
the
cmd_disable_vars_pr
branch
from
a9df525 to
b5b3e3d
Compare
|
Integration tests added |
sgotti
reviewed
Jan 22, 2020
There was a problem hiding this comment.
@camandel The integration tests looks great and made me remember that in #38 I haven't detailed that we should probably do this only on forked pull requests since pull requests from the same repos means that the users have access to the main repo.
So the option should be called something like PassVarsToForkedPR and we should check that the source and destination repositories are not the same. This will require extending the webhooks parsing the retrieve the base and head repositories and return in WebhookData something like a PRFromSameRepo bool.
camandel
force-pushed
the
cmd_disable_vars_pr
branch
from
b5b3e3d to
69fd8a4
Compare
camandel
changed the title
camandel
force-pushed
the
cmd_disable_vars_pr
branch
from
69fd8a4 to
182eb14
Compare
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
cmd: project option to disable passing variables to PR from forked repo
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
cmd: project option to disable passing variables to PR from forked repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add boolean parameter to choose if pass variables to runs even when triggered by PRs (option disabled by default):
agola project [create|update] --pass-vars-to-pr=true <...>Fixes #38