gitserver: add cleanup of old repos/branches #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
d4aa87c to
9632622
Compare
sgotti
requested changes
Jan 19, 2022
There was a problem hiding this comment.
@alessandro-sorint Thanks for your PR. Please see the inline comments. They're primarily related to the code and only some related to the logic. I haven't digged inside the real clean up logic but I think some things could be simplified a bit. I'll do this in the next review.
Can you please also add some tests?
P.S. Don't close this PR but just do your changes, squash your changes in a single commit and force push to your branch.
sgotti
changed the title
alessandro-sorint
force-pushed
the
repo-cleaner
branch
5 times, most recently
from
9128744 to
5a5987c
Compare
sgotti
requested changes
Jan 31, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
3 times, most recently
from
b27a220 to
7d80a71
Compare
sgotti
requested changes
Feb 1, 2022
sgotti
requested changes
Feb 1, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
10 times, most recently
from
4e6e436 to
33c14ae
Compare
alessandro-sorint
force-pushed
the
repo-cleaner
branch
2 times, most recently
from
e30e857 to
819fb71
Compare
sgotti
requested changes
Feb 4, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
2 times, most recently
from
435a2dc to
afdd153
Compare
sgotti
reviewed
Feb 4, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
3 times, most recently
from
c2c08f8 to
d4bf015
Compare
sgotti
reviewed
Feb 4, 2022
sgotti
reviewed
Feb 4, 2022
sgotti
reviewed
Feb 4, 2022
sgotti
reviewed
Feb 4, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
d4bf015 to
701ea46
Compare
sgotti
reviewed
Feb 4, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
701ea46 to
9671ca9
Compare
sgotti
reviewed
Feb 4, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
9671ca9 to
a6a02b3
Compare
sgotti
requested changes
Feb 7, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
a6a02b3 to
fa7e45a
Compare
sgotti
reviewed
Feb 8, 2022
alessandro-sorint
force-pushed
the
repo-cleaner
branch
from
fa7e45a to
9251a2a
Compare
sgotti
approved these changes
Feb 8, 2022
|
@alessandro-sorint Thanks! LGTM. Merging. |
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
gitserver: add cleanup of old repos/branches
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
gitserver: add cleanup of old repos/branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhancement: automatic cleanup of old repos/branches
#FIX #29