Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runservice: added logcleanerLoop for deleting older logs #294

Merged
merged 1 commit into from
Jul 13, 2022
Merged

runservice: added logcleanerLoop for deleting older logs #294

merged 1 commit into from
Jul 13, 2022

Conversation

alessandro-sorint
Copy link
Contributor

@alessandro-sorint alessandro-sorint commented Jan 25, 2022 •
edited
Loading

fix #47

@alessandro-sorint alessandro-sorint changed the title added runDataCleanerLoop for deleting older logs/workspace data Runservice: added runDataCleanerLoop for deleting older logs/workspace data Jan 26, 2022
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 2 times, most recently from 0ad1526 to b25ffb2 Compare February 1, 2022 08:51
@alessandro-sorint
Copy link
Contributor Author

@sgotti can you do the review please?

@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 4 times, most recently from 92547af to 1e27b3c Compare February 9, 2022 13:26
sgotti
sgotti requested changes Feb 10, 2022
View reviewed changes
internal/services/runservice/store/store.go Outdated Show resolved Hide resolved
internal/services/runservice/scheduler.go Outdated Show resolved Hide resolved
internal/services/runservice/runservice.go Show resolved Hide resolved
internal/services/runservice/scheduler.go Outdated Show resolved Hide resolved
tests/setup_test.go Outdated Show resolved Hide resolved
tests/setup_test.go Outdated Show resolved Hide resolved
tests/setup_test.go Outdated Show resolved Hide resolved
tests/setup_test.go Outdated Show resolved Hide resolved
internal/services/config/config.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint changed the title Runservice: added runDataCleanerLoop for deleting older logs/workspace data Runservice: added logCleanerLoop for deleting older logs Feb 10, 2022
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 2 times, most recently from 273d2d7 to fc49433 Compare February 10, 2022 11:18
sgotti
sgotti requested changes Feb 11, 2022
View reviewed changes
tests/setup_test.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 2 times, most recently from 8f59aa9 to 1373865 Compare February 11, 2022 15:29
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 5 times, most recently from 1bd610d to b823226 Compare March 1, 2022 08:47
@alessandro-sorint alessandro-sorint changed the title Runservice: added logCleanerLoop for deleting older logs runservice: added logcleanerLoop for deleting older logs Mar 1, 2022
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 2 times, most recently from 170527a to 6169c60 Compare March 3, 2022 08:35
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 2 times, most recently from 047a540 to e1aa805 Compare April 13, 2022 14:53
@alessandro-sorint alessandro-sorint force-pushed the delete-run-logs branch 5 times, most recently from 57c7120 to 31770c9 Compare June 13, 2022 12:23
@sgotti sgotti force-pushed the delete-run-logs branch from 31770c9 to 0cf6a0a Compare July 13, 2022 13:49
sgotti
sgotti approved these changes Jul 13, 2022
View reviewed changes
go.mod Outdated
@@ -34,6 +34,7 @@ require (
github.com/spf13/cobra v0.0.5
github.com/xanzy/go-gitlab v0.26.0
go.starlark.net v0.0.0-20200203144150-6677ee5c7211
go.uber.org/zap v1.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@sgotti sgotti merged commit 20ca985 into agola-io:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgotti sgotti sgotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runservice: log/workspace data deletion
2 participants
@alessandro-sorint @sgotti