runconfig: test task generation with on_skipped dependencies #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
Jan 31, 2022
There was a problem hiding this comment.
@alessandro-sorint Thanks for the PR. Can you please reduce the in/out data to reduce their size since they contains many stuff not needed to just test the on_skipped condition generation?
alessandro-sorint
force-pushed
the
test_on_skipped
branch
from
8c2cee3 to
60a7214
Compare
|
@sgotti i I reduced some datas in/out it's ok? |
alessandro-sorint
changed the title
alessandro-sorint
force-pushed
the
test_on_skipped
branch
from
60a7214 to
e517e4d
Compare
|
@alessandro-sorint Thanks! LGTM. Merging. |
sgotti
approved these changes
Feb 1, 2022
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
runconfig: test task generation with on_skipped dependencies
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
runconfig: test task generation with on_skipped dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test for PR #290