update to go 1.18 #336
Merged
update to go 1.18 #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sgotti can you restart the run? thanks |
sgotti
requested changes
Apr 14, 2022
.agola/config.jsonnet
Outdated
| @@ -107,7 +107,7 @@ local task_build_push_images(name, target, push) = | |||
| [ | |||
| task_build_go(version, arch), | |||
| ] | |||
| for version in ['1.15', '1.16'] | |||
| for version in ['1.17'] | |||
.agola/config.jsonnet
Outdated
| @@ -107,7 +107,7 @@ local task_build_push_images(name, target, push) = | |||
| [ | |||
| task_build_go(version, arch), | |||
| ] | |||
| for version in ['1.15', '1.16'] | |||
| for version in ['1.17'] | |||
There was a problem hiding this comment.
go 1.18 has already been released.
There was a problem hiding this comment.
ok @sgotti I change the PR to update go 1.18
alessandro-sorint
force-pushed
the
go1_17
branch
2 times, most recently
from
e88d70b to
94aa330
Compare
alessandro-sorint
force-pushed
the
go1_17
branch
from
94aa330 to
78de98b
Compare
|
Hi @sgotti, I updated golangci-lint to v1.45.2 version to resolve this error: goroutine 1 [running]: |
|
@sgotti can you restart the run? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update dockerfile and agola config for using golang 1.18