types: add custom Duration type #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
May 30, 2022
There was a problem hiding this comment.
@alessandro-sorint Thanks for the PR.
It should be better to put these files under services/types/duration[_test].go
I also think that using a struct with an embedded time.Duration could be cleaner.
alessandro-sorint
force-pushed
the
duration-custom
branch
from
35b905e to
a5ecd43
Compare
sgotti
requested changes
May 30, 2022
alessandro-sorint
force-pushed
the
duration-custom
branch
from
a5ecd43 to
f906304
Compare
sgotti
requested changes
May 31, 2022
services/types/duration_test.go
Outdated
| { | ||
| name: "test duration string", | ||
| expected: Duration{10 * time.Second}, | ||
| jsonDuration: ` |
There was a problem hiding this comment.
Just use one line to save some space.
services/types/duration_test.go
Outdated
| for _, tt := range tests { | ||
| result, err := json.Marshal(tt.duration) | ||
| if err != nil { | ||
| t.Fatal("failed to marshal duration: %w", err) |
There was a problem hiding this comment.
t.Fatalf and use %v since it's not error wrapping
services/types/duration_test.go
Outdated
| for _, tt := range tests { | ||
| var result testDurationType | ||
| if err := json.Unmarshal([]byte(tt.jsonDuration), &result); err != nil { | ||
| t.Fatal("failed to unmarshal json: %w", err) |
There was a problem hiding this comment.
t.Fatalf and use %v since it's not error wrapping
sgotti
requested changes
May 31, 2022
alessandro-sorint
force-pushed
the
duration-custom
branch
from
f906304 to
6e3030a
Compare
alessandro-sorint
force-pushed
the
duration-custom
branch
from
6e3030a to
d59ff9f
Compare
ok I renamed |
|
@alessandro-sorint Thanks merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Duration custom type for unmarshall json duration as human format or nanoseconds