executor: use a timeout for pod creation #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgotti can you restart and do the review please? |
sgotti
requested changes
Jun 7, 2022
There was a problem hiding this comment.
@alessandro-sorint Thanks for the PR. Some comments inline.
alessandro-sorint
force-pushed
the
tasksetup-timeout
branch
from
8f9738e to
da83811
Compare
sgotti
requested changes
Jun 10, 2022
alessandro-sorint
force-pushed
the
tasksetup-timeout
branch
2 times, most recently
from
8e8a4df to
d75e328
Compare
sgotti
changed the title
sgotti
requested changes
Jun 10, 2022
alessandro-sorint
force-pushed
the
tasksetup-timeout
branch
from
d75e328 to
f0d5950
Compare
sgotti
requested changes
Jun 10, 2022
alessandro-sorint
force-pushed
the
tasksetup-timeout
branch
from
f0d5950 to
26fcabb
Compare
sgotti
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #330
go.mod: updated k8s.io and dependencies to use context in k8s client
executor: added a timeout to the context used in NewPod