db: improve transactions handling #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
db_improve_tx_handling
branch
from
ecf2ed7 to
a321726
Compare
Since the transactions can be repeated (i.e. due to serializable errors in postgres or locked errors in sqlite) we should ensure that the objects are created inside the transaction or at the second execution the transaction will fail since the object revision has been updated by the previous one. This patch adds a txID to every transaction that it's set on objects fetched as an helper to ensure that the object is created/fetched inside the same transaction. To handle cases were the object is fetched/created outside the transaction we MUST manually ensure that the object is still valid (the tx logic must be self consistent) and only in such case restore the txID to the current transactions and revision to the original value at the start of the transaction.
sgotti
force-pushed
the
db_improve_tx_handling
branch
from
a321726 to
0d4c1ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the transactions can be repeated (i.e. due to serializable errors in postgres or locked errors in sqlite) we should ensure that the objects are created inside the transaction or at the second execution the transaction will fail since the object revision has been updated by the previous one.
This patch adds a txID to every transaction that it's set on objects fetched as an helper to ensure that the object is created/fetched inside the same transaction.
To handle cases were the object is fetched/created outside the transaction we MUST manually ensure that the object is still valid (the tx logic must be self consistent) and only in such case restore the txID to the current transactions and revision to the original value at the start of the transaction.