Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway: skip csrf check only on successful token auth #389

Merged
merged 1 commit into from
Mar 23, 2023
Merged

gateway: skip csrf check only on successful token auth #389

merged 1 commit into from
Mar 23, 2023

Conversation

sgotti
Copy link
Member

@sgotti sgotti commented Mar 23, 2023

  • skip csrf check only on successful token auth and not only if the token has been provided.
  • improve checkers logic to tell when auth should fail in the checker response so we could return an unauthorized error

@sgotti
gateway: skip csrf check only on successful token auth
5241bae 
* skip csrf check only on successful token auth and not only if the
  token has been provided.
* improve checkers logic to tell when auth should fail in the checker
  response so we could return an unauthorized error
@sgotti sgotti merged commit 515ee31 into agola-io:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sgotti