[stable/verdaccio] add optional fixed nodePort to service when NodePo…

…rt service type used (helm#10662) Signed-off-by: James Sidhu <[email protected]>
agolo · Jan 16, 2019 · 3f4f214 · 3f4f214
1 parent 87ffc63
commit 3f4f214
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/stable/verdaccio/Chart.yaml b/stable/verdaccio/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: A lightweight private npm proxy registry (sinopia fork)
 name: verdaccio
-version: 0.6.0
+version: 0.6.1
 appVersion: 3.10.0
 home: http://www.verdaccio.org
 icon: https://raw.githubusercontent.com/verdaccio/verdaccio/master/assets/bitmap/logo/logo-twitter.png

diff --git a/stable/verdaccio/README.md b/stable/verdaccio/README.md
@@ -55,7 +55,7 @@ and their default values.
 | `customConfigMap`                  | Use a custom ConfigMap                                          | `false`                                                  |
 | `image.pullPolicy`                 | Image pull policy                                               | `IfNotPresent`                                           |
 | `image.repository`                 | Verdaccio container image repository                            | `verdaccio/verdaccio`                                    |
-| `image.tag`                        | Verdaccio container image tag                                   | `3.10.0`                                                    |
+| `image.tag`                        | Verdaccio container image tag                                   | `3.10.0`                                                 |
 | `nodeSelector`                     | Node labels for pod assignment                                  | `{}`                                                     |
 | `persistence.accessMode`           | PVC Access Mode for Verdaccio volume                            | `ReadWriteOnce`                                          |
 | `persistence.enabled`              | Enable persistence using PVC                                    | `true`                                                   |
@@ -73,6 +73,7 @@ and their default values.
 | `service.loadBalancerIP`           | IP address to assign to load balancer (if supported)            | `""`                                                     |
 | `service.loadBalancerSourceRanges` | List of IP CIDRs allowed access to load balancer (if supported) | `[]`                                                     |
 | `service.port`                     | Service port to expose                                          | `4873`                                                   |
+| `service.nodePort`                 | Service port to expose                                          | none                                                     |
 | `service.type`                     | Type of service to create                                       | `ClusterIP`                                              |
 
 Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,

diff --git a/stable/verdaccio/templates/service.yaml b/stable/verdaccio/templates/service.yaml
@@ -29,6 +29,11 @@ spec:
       targetPort: http
       protocol: TCP
       name: {{ .Values.service.name }}
+      {{- if contains "NodePort" .Values.service.type }}
+      {{- if .Values.service.nodePort }}
+      nodePort: {{ .Values.service.nodePort }}
+      {{- end }}
+      {{- end }}
   selector:
     app: {{ template "verdaccio.name" . }}
     release: {{ .Release.Name }}

diff --git a/stable/verdaccio/values.yaml b/stable/verdaccio/values.yaml
@@ -16,6 +16,7 @@ service:
   loadBalancerSourceRanges: []
   port: 4873
   type: ClusterIP
+  # nodePort: 31873
 
 ## Node labels for pod assignment
 ## Ref: https://kubernetes.io/docs/user-guide/node-selection/